Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-29437: install the smaller openshift-kubelet package #1449

Merged
merged 1 commit into from
Feb 27, 2024
Merged

OCPBUGS-29437: install the smaller openshift-kubelet package #1449

merged 1 commit into from
Feb 27, 2024

Conversation

sdodson
Copy link
Member

@sdodson sdodson commented Feb 26, 2024

The packaging has recently been refactored to offer a kubelet only package, which is all that RHCOS should require. This removes extraneous server binaries kube-apiserver, kube-controller-manager, and kube-scheduler

@sdodson
OCPBUGS-29437: install the smaller openshift-kubelet package
95bf111 
The packaging has recently been refactored to offer a kubelet only package,
which is all that RHCOS should require. This removes extraneous server
binaries kube-apiserver, kube-controller-manager, and kube-scheduler
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 26, 2024
@openshift-ci-robot
Copy link

@sdodson: This pull request references Jira Issue OCPBUGS-29437, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The packaging has recently been refactored to offer a kubelet only package, which is all that RHCOS should require. This removes extraneous server binaries kube-apiserver, kube-controller-manager, and kube-scheduler

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 26, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 26, 2024
Merged
@sdodson
Copy link
Member Author

sdodson commented Feb 26, 2024

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 26, 2024

@sdodson: The following commands are available to trigger required jobs:

  • /test images
  • /test rhcos-9-build-test-metal
  • /test rhcos-9-build-test-qemu
  • /test scos-9-build-test-metal
  • /test scos-9-build-test-qemu
  • /test validate

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member Author

sdodson commented Feb 26, 2024

/test all

@jlebon
Copy link
Member

jlebon commented Feb 26, 2024

/approve

CI should be fixed by #1448.
/retest

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2024
@sdodson
Copy link
Member Author

sdodson commented Feb 26, 2024

/test ci/prow/rhcos-9-build-test-metal

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 26, 2024

@sdodson: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test images
  • /test rhcos-9-build-test-metal
  • /test rhcos-9-build-test-qemu
  • /test scos-9-build-test-metal
  • /test scos-9-build-test-qemu
  • /test validate

Use /test all to run all jobs.

In response to this:

/test ci/prow/rhcos-9-build-test-metal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlebon
Copy link
Member

jlebon commented Feb 26, 2024

Looks like the rhcos-9 metal wasn't retesting on top of #1448.

/retest

@sdodson sdodson marked this pull request as ready for review February 26, 2024 20:50
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2024
@travier
Copy link
Member

travier commented Feb 26, 2024

/retest

travier
travier approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, sdodson, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 27, 2024

@sdodson: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 00bbdb2 into openshift:master Feb 27, 2024
7 checks passed
@openshift-ci-robot
Copy link

@sdodson: Jira Issue OCPBUGS-29437: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29437 has been moved to the MODIFIED state.

In response to this:

The packaging has recently been refactored to offer a kubelet only package, which is all that RHCOS should require. This removes extraneous server binaries kube-apiserver, kube-controller-manager, and kube-scheduler

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sdodson sdodson mentioned this pull request Mar 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travier travier travier approved these changes

@madhu-pillai madhu-pillai Awaiting requested review from madhu-pillai

Assignees

@travier travier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdodson @openshift-ci-robot @jlebon @travier